refactor: add custom errors for ACL and NatSpec updates #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PacificYield
changed the title
jatZama
reviewed
Dec 23, 2024
jatZama
reviewed
Dec 23, 2024
jatZama
reviewed
Dec 23, 2024
PacificYield
force-pushed
the
acl-custom-errors
branch
2 times, most recently
from
bd1507a to
0fec7c4
Compare
PacificYield
changed the title
PacificYield
force-pushed
the
acl-custom-errors
branch
2 times, most recently
from
2b667df to
63233e6
Compare
PacificYield
force-pushed
the
acl-custom-errors
branch
from
63233e6 to
8c0a931
Compare
jatZama
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains custom errors for the
ACL.solcontracts, a few unit tests, and adds NatSpec changes forACL.sol.