feat: make ciphertext inputs global per request #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniupop
approved these changes
Aug 30, 2024
Instead of passing in ciphertexts as part of the SyncInput, pass them globally for the whole request. Decompress them into a map that lives for the duration of the request. Computations then refer to ciphertexts in the map via handles, applying to inputs, compressed ciphertexts and results. Above also allows for use of results as inputs in subsequent computations.
dartdart26
force-pushed
the
petar/deduplicate-ciphertext-inputs
branch
from
eab925b to
cc72203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing in ciphertexts as part of the SyncInput, pass them globally for the whole request. Decompress them into a map that lives for the duration of the request. Computations then refer to ciphertexts in the map via handles, applying to inputs, compressed ciphertexts and results.
Above also allows for use of results as inputs in subsequent computations.