fix(concrete_npe): fix base log in the pbs noise #130

agnesLeroy · 2022-01-28T12:55:29Z

The base log value was wrong in the PBS noise formula.

(Use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
The PR description links to the related issue (to link an issue, use '#XXX'.)
The tests on AWS have been launched and are successful (apply the aws_test to the PR to launch the tests on AWS)
The draft release description has been updated
Check for breaking changes and add them to commit message following the conventional commit specification

fix(concrete_npe): fix base log in the pbs noise

51c3d93

agnesLeroy requested a review from jborfila January 28, 2022 12:55

jborfila approved these changes Jan 28, 2022

View reviewed changes

agnesLeroy added the aws_test A label to trigger the test execution on aws instance label Jan 28, 2022

github-actions bot removed the aws_test A label to trigger the test execution on aws instance label Jan 28, 2022

aPere3 merged commit 9e25a62 into master Jan 28, 2022

aPere3 deleted the fix/npe_pbs_noise branch January 28, 2022 15:37

Provide feedback