Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): lint dockerfiles using hadolint #1113

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat(ci): lint dockerfiles using hadolint #1113

merged 2 commits into from
Oct 24, 2024

Conversation

youben11
Copy link
Member

@youben11 youben11 commented Oct 23, 2024

This adds hadolint linter for all current dockerfiles.

  • New dockerfiles should be added to the workflow for linting
  • CI fail if any rule is violated (I linted everything so it's green now)
  • Exceptions can be made using # hadolint ignore=DLXXXX

@cla-bot cla-bot bot added the cla-signed label Oct 23, 2024
@youben11 youben11 force-pushed the ci/docker-checks branch 2 times, most recently from 2afefa7 to d3c61d5 Compare October 23, 2024 09:30
Copy link
Contributor

@aquint-zama aquint-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @youben11, thanks for this, lgtm!

@youben11 youben11 merged commit 76be2d8 into main Oct 24, 2024
27 checks passed
@youben11 youben11 deleted the ci/docker-checks branch October 24, 2024 07:25
@BourgerieQuentin
Copy link
Member

See my slack message I think is better to use a multiple files check instead of a step for each known files as we can miss in the future to add.

@youben11
Copy link
Member Author

@BourgerieQuentin done in #1119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants