Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): add zero noise and max noise ops #1092

Closed
wants to merge 26 commits into from
Closed

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Oct 7, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: b0710a4 Previous: aae579f Ratio
v0 PBS table generation 63747455 ns/iter (± 1994675) 58670470 ns/iter (± 409081) 1.09
v0 PBS simulate dag table generation 40239515 ns/iter (± 557585) 39439472 ns/iter (± 225653) 1.02
v0 WoP-PBS table generation 49675256 ns/iter (± 1178826) 49686213 ns/iter (± 1564842) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's live review, got the need of the new optimizer operators but not the motivation of some refactoring. Meeting scheduled ✔️

@aPere3 aPere3 force-pushed the alex/optimizer_max branch 4 times, most recently from a480950 to 763177e Compare October 15, 2024 14:21
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@aPere3 aPere3 force-pushed the alex/optimizer_max branch from 763177e to 25d3666 Compare October 15, 2024 14:43
youben11 and others added 20 commits October 17, 2024 11:39
from the docs: The jobs.<job_id>.if condition is evaluated before jobs.<job_id>.strategy.matrix is applied. So we can't just use matrix.dockerfile so we have to build both images if one of the two files change, or we will have to split this into two.

it was previously built everytime due to the evaluation of
matrix.dockerfile to an empty string

https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif
@aPere3
Copy link
Collaborator Author

aPere3 commented Oct 17, 2024

postponed by #1104

@aPere3 aPere3 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants