-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(optimizer): add zero noise and max noise ops #1092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: b0710a4 | Previous: aae579f | Ratio |
---|---|---|---|
v0 PBS table generation |
63747455 ns/iter (± 1994675 ) |
58670470 ns/iter (± 409081 ) |
1.09 |
v0 PBS simulate dag table generation |
40239515 ns/iter (± 557585 ) |
39439472 ns/iter (± 225653 ) |
1.02 |
v0 WoP-PBS table generation |
49675256 ns/iter (± 1178826 ) |
49686213 ns/iter (± 1564842 ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's live review, got the need of the new optimizer operators but not the motivation of some refactoring. Meeting scheduled ✔️
compilers/concrete-compiler/compiler/lib/Dialect/FHE/Analysis/ConcreteOptimizer.cpp
Show resolved
Hide resolved
a480950
to
763177e
Compare
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
763177e
to
25d3666
Compare
from the docs: The jobs.<job_id>.if condition is evaluated before jobs.<job_id>.strategy.matrix is applied. So we can't just use matrix.dockerfile so we have to build both images if one of the two files change, or we will have to split this into two. it was previously built everytime due to the evaluation of matrix.dockerfile to an empty string https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif
postponed by #1104 |
No description provided.