Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix hybrid model glwe lora mlp #942

Merged
merged 6 commits into from
Nov 21, 2024
Merged

chore: fix hybrid model glwe lora mlp #942

merged 6 commits into from
Nov 21, 2024

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Nov 14, 2024

@cla-bot cla-bot bot added the cla-signed label Nov 14, 2024
Copy link

⚠️ This PR contains unsigned commits. To get your PR merged, please sign those commits (git rebase --exec 'git commit -S --amend --no-edit -n' @{upstream}) and force push them to this branch (git push --force-with-lease).

If you're new to commit signing, there are different ways to set it up:

Sign commits with gpg

Follow the steps below to set up commit signing with gpg:

  1. Generate a GPG key
  2. Add the GPG key to your GitHub account
  3. Configure git to use your GPG key for commit signing
Sign commits with ssh-agent

Follow the steps below to set up commit signing with ssh-agent:

  1. Generate an SSH key and add it to ssh-agent
  2. Add the SSH key to your GitHub account
  3. Configure git to use your SSH key for commit signing
Sign commits with 1Password

You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.

Learn how to use 1Password to sign your commits.

Watch the demo

@jfrery jfrery force-pushed the fix_hybrid_model_glwe branch from 3950ab9 to ace90dd Compare November 14, 2024 20:07
@jfrery jfrery marked this pull request as ready for review November 15, 2024 07:44
@jfrery jfrery requested a review from a team as a code owner November 15, 2024 07:44
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a way to ensure we don't keygen every time the forward of the hybrid model is called

src/concrete/ml/torch/hybrid_model.py Show resolved Hide resolved
@jfrery jfrery force-pushed the fix_hybrid_model_glwe branch from b74082b to 76f409a Compare November 18, 2024 08:39
Copy link

⚠️ Known flaky tests have been rerun ⚠️

One or several tests initially failed but were identified as known flaky. tests. Therefore, they have been rerun and passed. See below for more details.

Failed tests details

Known flaky tests that initially failed:

  • tests/torch/test_compile_torch.py::test_compile_torch_or_onnx_conv_networks[True-True-CNN_grouped-relu]- tests/torch/test_compile_torch.py::test_compile_torch_or_onnx_networks[get_and_compile--FHE_simulation-BranchingGemmModule-5-relu]

Copy link

Coverage failed ❌

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name                                                     Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------------
src/concrete/ml/quantization/linear_op_glwe_backend.py      56     19    66%   42, 100-150
src/concrete/ml/torch/hybrid_model.py                      183      3    98%   421, 478, 482
--------------------------------------------------------------------------------------
TOTAL                                                     8421     22    99%

60 files skipped due to complete coverage.

@jfrery jfrery merged commit 7d69721 into main Nov 21, 2024
34 of 41 checks passed
@jfrery jfrery deleted the fix_hybrid_model_glwe branch November 21, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants