-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: propagate GLWE config on hybrid MLP unit test #928
fix: propagate GLWE config on hybrid MLP unit test #928
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @alinealfa on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the refactoring here!
Signed-off-by: Aline Almeida <[email protected]>
e27c7db
to
b0133da
Compare
Thanks @andrei-stoian-zama. I updated the commit as the CI was enforcing signature. |
@alinealfa , as we require signed commits only from approved Zama employees, I needed to re-base your PR . It's here: #935 and I'll close this one. |
Got it. So should external contributors not sign the commit? Actually the Contributing doc does not indicate need of signature. I ended up adding so we could get the CI/tests unblocked. |
Notes
Fix #927 - Address
test_hybrid_converter.py
failure on MacOSThis fix propagates the GLWE configuration in the hybrid MLP unit test.
Review needed to confirm if this aligns with the test's original intended behavior.
Testing
Executed the
make
tasks as outlined in contributing.md. For pytest, used pytest_no_flaky due to a local unrelatedtest_brevitas_qat.py
test failure, which is known to be flaky.