-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support 3.12 python #847
Conversation
2fbfee6
to
162765e
Compare
4c4632b
to
11292f7
Compare
Apparently, there are already things to fix regarding CP for 3.11, https://zama-ai.slack.com/archives/C044G400J6N/p1724831478822349?thread_ts=1724772713.112659&cid=C044G400J6N So let's wait here |
CP 3.11 installation was fixed: it was a bad command line. |
@andrei-stoian-zama could you give a try to this branch with 3.12, please? if it works locally for you, we might merge this. |
Looks good to me, but I haven't ran it on 3.12. |
Added a reversible commit to try 3.12 on the PR |
We have an issue in
|
Trying on my machine |
Trying to see if I can change a bit the toml and make sync_env with 3.12 |
Well, already, CP is not installable with 3.12, I'm going to ask the team:
|
@andrei-stoian-zama : do I let you finish this PR? |
f430aa8
to
3a75af8
Compare
12bd910
to
a043f51
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need the CML 3.12 test to pass -> https://github.com/zama-ai/concrete-ml/actions/runs/12032176976
@@ -24,7 +24,7 @@ | |||
}, | |||
{ | |||
"cell_type": "code", | |||
"execution_count": 1, | |||
"execution_count": null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notebooks haven't run normally, it's worth refreshing them with the CI action
Signed-off-by: Andrei Stoian <[email protected]>
61e9e25
to
867988e
Compare
Coverage passed ✅Coverage details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the test speed up!
Adding support for 3.12
closes #https://github.com/zama-ai/concrete-ml-internal/issues/4083