phc: add new metric to counter number of unique requests mitigated #3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
changed the base branch from
master
to
phc/refactor-tests-and-add-extra
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
Signed-off-by: Mustafa Abdelrahman <[email protected]>
MustafaSaber
force-pushed
the
phc/rps-mitigated
branch
from
bb66ca3 to
c4ae32e
Compare
|
Metrics will differ when we have more than one unhealthy endpoint that's why we landed #3058 first |
Signed-off-by: Mustafa Abdelrahman <[email protected]>
|
👍 |
1 similar comment
|
👍 |
This was referenced May 13, 2024
JanardhanSharma
pushed a commit
to JanardhanSharma/skipper
that referenced
this pull request
Jul 19, 2024
…alando#3059) Signed-off-by: Mustafa Abdelrahman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #3035 and #2346
depends on #3058