Create a minimum failure ratio for enabling PHC (#3046)

It is hardcoded to 5% now, but we plan to make it configurable. Signed-off-by: Roman Zavodskikh <[email protected]> Co-authored-by: Roman Zavodskikh <[email protected]>
zalando · Apr 26, 2024 · f6bf033 · f6bf033
1 parent 9570e4f
commit f6bf033
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/proxy/healthy_endpoints.go b/proxy/healthy_endpoints.go
@@ -22,7 +22,7 @@ func (h *healthyEndpoints) filterHealthyEndpoints(ctx *context, endpoints []rout
 	filtered := make([]routing.LBEndpoint, 0, len(endpoints))
 	for _, e := range endpoints {
 		dropProbability := e.Metrics.HealthCheckDropProbability()
-		if p < dropProbability {
+		if dropProbability > 0.05 && p < dropProbability {
 			ctx.Logger().Infof("Dropping endpoint %q due to passive health check: p=%0.2f, dropProbability=%0.2f",
 				e.Host, p, dropProbability)
 			metrics.IncCounter("passive-health-check.endpoints.dropped")