Fix X-RateLimit headers handling when using CompositeDelayFunction #1672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since RateLimitResetDelayFunction and RetryAfterDelayFunction are returning
Duration.ofMinutes(-1)
instead of null as the default value since Riptide 4, it is needed to check not only for non-null values but also if there are any non-default delays in the CompositeDelayFunction.Motivation and Context
Duration.ofMinutes(-1)
linkAs Riptide 4, if CompositeDelayFunction consists of two functions (A and B) and A returns default value and B returns a positive meaningful value, the default value would be taken since it is not null.
The issue is opened here.
Types of changes
Checklist: