Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make current image title and pixelSize editable #123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

moonayyur
Copy link
Collaborator

closes #114

Copy link

cloudflare-workers-and-pages bot commented May 31, 2024

Deploying pixelium with  Cloudflare Pages  Cloudflare Pages

Latest commit: d974d95
Status: ✅  Deploy successful!
Preview URL: https://58faa486.pixelium.pages.dev
Branch Preview URL: https://114-edit-image-metainfo.pixelium.pages.dev

View logs

@moonayyur moonayyur marked this pull request as ready for review May 31, 2024 10:53
@stropitek
Copy link
Contributor

Isn't the term for pixel size in microscopy "resolution"? It's also the term used when scanning documents for example (but expressed in different units)

@stropitek stropitek requested a review from lpatiny June 3, 2024 08:33
@lpatiny
Copy link
Contributor

lpatiny commented Jun 3, 2024

I don't think we should rename the property of the resolution because resolution refers to the capacity of the instrument and it not related to the pixel size: https://www.nanoscience.com/blogs/understanding-the-difference-between-magnification-and-resolution-in-scanning-electron-microscopy/

@stropitek
Copy link
Contributor

Do you have another term in mind? Because it would be good to find a term that is not tied to a specific unit. For images scanned with a digital scanner, the property would be defined in DPI and not in distance / px.

@lpatiny
Copy link
Contributor

lpatiny commented Jun 4, 2024

It can be converted to DPI internally if you want but this value will not speak to the scientist. At the end the annotations of the ROIs should be in 'nm' or 'nm^2' for surfaces for example.

Very often there is a scale on the image as well so this calculation of the DPI can be done by drawing a line but this will require some developments.

2024-06-04 13 54 05

@stropitek
Copy link
Contributor

I don't "want" to use DPI, but someone might happen to know that an image has a certain resolution in DPI, and not in any other unit and does not have a reference on the image. We can imagine that in the future we can enter this field in any units that best fits the use case, and then pixelium can convert it, not the other way around.

Maybe use "pixel density" instead of "pixel size"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit image metainfo
3 participants