Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid conflicts when deployed by ArgoCD #147

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Avoid conflicts when deployed by ArgoCD #147

merged 2 commits into from
Oct 11, 2024
+124 −15

Commits on Oct 11, 2024

  1. Avoid conflicts when deployed by ArgoCD 

    This change introduces a black list for labels like the one already
existing for metadata.

The list contains one entry for the prefix "app.kubernetes.io". The
label "app.kubernetes.io/instance" is per default used by ArgoCD to
track resources, which causes copied Secrets to be potentially deleted
again by ArgoCD. Also labels with prefix "app.kubernetes.io" are in
general very specific to the resources in their respective namespace and
therefore shouldn't probably be automatically copied to resources in
other namespaces anyway.

In order to avoid code duplication the filtering is delegated to an
embedded function filter_dict.

Signed-off-by: Max Harmathy <[email protected]>
    @harmathy
    harmathy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    60d5abc View commit details
    Browse the repository at this point in the history

  2. Unit test create_secret_metadata function 

    This tests the create_secret_metadata function against some combinations
of annotations and labels.

Signed-off-by: Max Harmathy <[email protected]>
    @harmathy
    harmathy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2330b7d View commit details
    Browse the repository at this point in the history