Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose the default value for replace_existing #145

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

NerdyShawn
Copy link
Contributor

It wasn't apparent to me that the replace_existing parameter was available until I reviewed the documentation. This is mostly because I converted the helm chart to be a flux helmRelease which doesn't translate the comments to the artifact for flux's helm-controller. My thought was rather than uncomment the lines in the value just show it with its default of false and that way users can just change the value in the chart to override.

For example with flux creation

flux create hr cluster-secret --target-namespace=clustersecret --source=HelmRepository/cluster-secret --chart=cluster-secret --values=./values.yaml --export > helmrelease-cluster-secret.yaml

viewing the artifiact below that the helm-controller will use you can see that its not immediately apparent that replace_existing value is even used.

cat helmrelease-cluster-secret.yaml 
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: cluster-secret
  namespace: flux-system
spec:
  chart:
    spec:
      chart: cluster-secret
      reconcileStrategy: ChartVersion
      sourceRef:
        kind: HelmRepository
        name: cluster-secret
  interval: 1m0s
  targetNamespace: clustersecret
  values:
    affinity: {}
    image:
      repository: quay.io/clustersecret/clustersecret
      tag: 0.0.11
    imagePullSecrets: []
    kubernetesClusterDomain: cluster.local
    nodeSelector: {}
    podAnnotations: {}
    tolerations: []

@zakkg3
Copy link
Owner

zakkg3 commented Oct 11, 2024

makes sense.

this needs a chart bump... check the tests.

Old chart version: 0.4.3
New chart version: 0.4.3

Thanks

@zakkg3
Copy link
Owner

zakkg3 commented Oct 12, 2024

some things are missing.
please take this commit as a reference cbde31a
I also take this opportunity to release a new image with some bug fixes.
I just created a new tag 0.0.12 so please update the image to that and we are ready to merge.

thanks!

Copy link
Owner

@zakkg3 zakkg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zakkg3 zakkg3 merged commit 706766b into zakkg3:master Oct 13, 2024
14 checks passed
@NerdyShawn NerdyShawn deleted the replaceExistingChartValuesExpose branch October 13, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants