Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement recipe search #37

Merged
merged 1 commit into from
Nov 20, 2023
Merged

feat: implement recipe search #37

merged 1 commit into from
Nov 20, 2023

Conversation

NilinReza
Copy link
Collaborator

  • Add recipe-list component
  • Add search to home component
  • Add getRecipesByQuery() method to recipe service
  • Add GetRecipesByQuery() to RecipeController

gh-16

zaidi-01
zaidi-01 requested changes Nov 20, 2023
View reviewed changes
Copy link
Owner

@zaidi-01 zaidi-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit history is messed up, there are duplicate and merge commits. Rebase your changes on top of main.

zaidi-01
zaidi-01 reviewed Nov 20, 2023
View reviewed changes
client/src/app/home/home.component.html Outdated Show resolved Hide resolved
client/src/app/home/home.component.html Outdated Show resolved Hide resolved
client/src/app/app.module.ts Outdated Show resolved Hide resolved
client/src/app/home/home.component.ts Outdated Show resolved Hide resolved
client/src/app/recipe-list/recipe-list.component.ts Outdated Show resolved Hide resolved
client/src/services/recipe/recipe.service.ts Outdated Show resolved Hide resolved
server/Controllers/RecipeController.cs Outdated Show resolved Hide resolved
@NilinReza NilinReza requested a review from zaidi-01 November 20, 2023 07:27
StevieShibly8
StevieShibly8 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@StevieShibly8 StevieShibly8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@NilinReza @zaidi-01 @StevieShibly8
feat: implement recipe search
94b017e 
- Add recipe-list and recipe-search components
- Replace home component with recipe-search
- Add searchRecipes method to recipe service
- Add SearchRecipes method to RecipeController

gh-16

Co-authored-by: Syed Zaidi <[email protected]>
Co-authored-by: Zubair Shibly <[email protected]>
@NilinReza NilinReza force-pushed the feat/recipe-list branch 2 times, most recently from 1f9b5dd to 94b017e Compare November 20, 2023 07:49
@NilinReza NilinReza merged commit e5e43ae into main Nov 20, 2023
1 check passed
@NilinReza NilinReza deleted the feat/recipe-list branch November 20, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevieShibly8 StevieShibly8 StevieShibly8 approved these changes

@zaidi-01 zaidi-01 zaidi-01 approved these changes

@JJTomines JJTomines Awaiting requested review from JJTomines

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NilinReza @zaidi-01 @StevieShibly8