-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds AMSTRADCPCPLUS and SAVECPR #217
Conversation
Great job for Amstrad owners ! |
I had a quick initial look and this looks very good, thank you. One question I have is what is the exact relation between 464, 6218 and plus. From a quick look the Plus seems to be same as 6128, only having more RAM, so it's not clear why for example CDT wouldn't be beneficial also for Plus machine. And other way, the .cpr don't support the smaller ones? If the directives could be useful in cross-way, I would suggest to add the Plus into the current cpc family ( |
Thanks for the quick review. The amstrad plus machines are:
To keep code simple, I chose to focus the amstradcpcplus device to support the cartridge through the cpr file format. The 32 pages available for this device are more an image of the cartridge than an image of the ram (extra 64k of ram for the 6128(+) is mostly useless when you use a cartridge). In a first patch, I added sna and cdt feature, then I changed my mind, because some more device should be added to manage ram differences between 464+, GX4000, 6128+, and hardware support differences (GX4000 only support cartridge). But this could be introduced in a future patch. |
Anything new ? |
Sorry, I had lately to minimize the time for hobby coding stuff. I do have this pretty high on the list, and I'm hoping to get back to it still this year, but can't give any promises right now. But I don't want it to fizzle out, should be part of next release, whenever that happens. |
merged manually on master branch, TY lordheavy. |
AMSTRADCPCPLUS
device (similar to AMSTRADCPC6128 but with 32 pages).SAVECPR
directive (allows to save the memory in a cpr file per blocks of 16 KiB - supported by cpc+ emulators).I updated documentation and kate syntax highlighting.
Tests are missing - help needed !All current tests passed.