Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #13

Merged
merged 1 commit into from
May 15, 2017
Merged

Update README.md #13

merged 1 commit into from
May 15, 2017

Conversation

Zifius
Copy link
Contributor

@Zifius Zifius commented May 15, 2017

Removed sudo as bash_completion.d folder is owned by current user

@yvoronoy yvoronoy merged commit 9ff4b8f into yvoronoy:master May 15, 2017
@Zifius Zifius deleted the fix-readme branch May 15, 2017 20:31
@yvoronoy
Copy link
Owner

@Zifius
Alexander, thank you for contribution 👍

@Zifius
Copy link
Contributor Author

Zifius commented May 15, 2017

Cheers @yvoronoy. Looking forward to zsh support :)

@yvoronoy
Copy link
Owner

@Zifius actually I don't use ZSH, but I've found some solution on StackOverflow and looks like it has to be working under ZSH without additional changes.
Could you check if it works for you? http://stackoverflow.com/questions/3249432/i-have-a-bash-tab-completion-script-is-there-a-simple-way-to-use-it-from-zsh

if so, probably we have to update README

@Zifius
Copy link
Contributor Author

Zifius commented May 15, 2017

@yvoronoy it indeed works but slowdowns initial prompt significantly, also throws errors:

_magento2:4: command not found: get_comp_words_by_reg
_magento2:98: command not found: __ltrim_colon_completions

So native implementation would be beneficial, e.g. as part of https://github.com/zsh-users/zsh-completions, anyway zsh completion is much better in terms of explaining which command does what. I'll try to find time to implement

By the way I needed #12 to be able to autocomplete with php bin/magento or bin/magento

@yvoronoy
Copy link
Owner

@Zifius I see, thank you for checking.
It would be really cool if you find time to implement it.

It's weird why it doesn't work with relative paths? On my OSX and Linux works as expected. But probably I have to add it since few people complain about it.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants