-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid classpath conflict with rhino #179
Open
mcucchiara
wants to merge
9
commits into
yui:master
Choose a base branch
from
mcucchiara:avoid-classpath-conflict-with-rhino
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Avoid classpath conflict with rhino #179
mcucchiara
wants to merge
9
commits into
yui:master
from
mcucchiara:avoid-classpath-conflict-with-rhino
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No backward compatibility, since the way of consuming Rhino from the library has changed.
It looks good to me. Hope it gets merged into master soon! :D |
Any chance this can be merged? It would remove a lot of pain from our project :-/ |
Looking forward to this being merged too :) |
Can we get this released already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change will solve the existing conflict coming from the modified version of Rhino shipped with the library.
Tests outcome is consistent with the current status.
See: