-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting Collation - deterministic attribute and Merge statement #2154
Conversation
DETERMINISTIC_OPTION_WITH_COLLATION = "DETERMINISTIC_OPTION_WITH_COLLATION" | ||
DETERMINISTIC_OPTION_WITH_COLLATION_NAME = "Deterministic attribute in collation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about naming the issue as Nondeterministic Collation
As per the docs - 'A collation is either deterministic or nondeterministic.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't rename the issue as Non-deterministic collation as we are not reporting the non-deterministic one only, we are reporting both the cases if deterministic or nondeterministic, as the deterministic option with collation is completely not supported in YB so it errors out if it is true even
CREATE COLLATION .... (..., deterministic = true);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, what is the default if nothing is provided?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its Deterministic by default
Describe the changes in this pull request
COLLATION
object from PG. https://yugabyte.atlassian.net/browse/DB-14236Describe if there are any user-facing changes
Added feature in Unsupported Feature for Deterministic attribute in collation
Added feature for DMLs having MERGE statement -
How was this pull request tested?
added unit and end-to-end tests
Does your PR have changes that can cause upgrade issues?