Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting Collation - deterministic attribute and Merge statement #2154

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

priyanshi-yb
Copy link
Contributor

@priyanshi-yb priyanshi-yb commented Jan 6, 2025

Describe the changes in this pull request

  1. Reporting deterministic option (either true or false) as it is completely not supported in COLLATION object from PG. https://yugabyte.atlassian.net/browse/DB-14236
  2. Reporting MERGE statement as its >=PG15 feature. https://yugabyte.atlassian.net/browse/DB-14222

Describe if there are any user-facing changes

Added feature in Unsupported Feature for Deterministic attribute in collation
Screenshot 2025-01-06 at 9 26 30 PM

Added feature for DMLs having MERGE statement -

Screenshot 2025-01-06 at 9 27 09 PM

How was this pull request tested?

added unit and end-to-end tests

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

@priyanshi-yb priyanshi-yb marked this pull request as ready for review January 7, 2025 05:36
Comment on lines +82 to +83
DETERMINISTIC_OPTION_WITH_COLLATION = "DETERMINISTIC_OPTION_WITH_COLLATION"
DETERMINISTIC_OPTION_WITH_COLLATION_NAME = "Deterministic attribute in collation"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about naming the issue as Nondeterministic Collation

As per the docs - 'A collation is either deterministic or nondeterministic.'

Copy link
Contributor Author

@priyanshi-yb priyanshi-yb Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't rename the issue as Non-deterministic collation as we are not reporting the non-deterministic one only, we are reporting both the cases if deterministic or nondeterministic, as the deterministic option with collation is completely not supported in YB so it errors out if it is true even

CREATE COLLATION .... (..., deterministic = true);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok, what is the default if nothing is provided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its Deterministic by default

yb-voyager/src/query/queryissue/issues_ddl.go Show resolved Hide resolved
yb-voyager/src/query/queryissue/issues_dml.go Show resolved Hide resolved
yb-voyager/src/query/queryparser/traversal_proto.go Outdated Show resolved Hide resolved
@priyanshi-yb priyanshi-yb merged commit 824dbf7 into main Jan 9, 2025
67 checks passed
@priyanshi-yb priyanshi-yb deleted the priyanshi/report-collate-merge branch January 9, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants