Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Not logging the source-replica-db-password in the import-data-to-source-replica command log file #2105

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

priyanshi-yb
Copy link
Contributor

@priyanshi-yb priyanshi-yb commented Dec 19, 2024

Describe the changes in this pull request

Fixing logging of source-replica db password in log file
https://yugabyte.atlassian.net/browse/DB-14595

Describe if there are any user-facing changes

N/A

How was this pull request tested?

Manually,

2024-12-19 16:29:23.042375 INFO logging.go:76 Args: [yb-voyager import data to source-replica --export-dir /Users/priyanshigupta/Documents/voyager/yb-voyager/migtests/tests/pg/basic-public-live-test/export-dir --source-replica-db-user postgres --source-replica-db-name ff_db --source-replica-db-password XXX --disable-pb true --send-diagnostics=false --parallel-jobs 3 --max-retries 1 --source-replica-db-host 127.0.0.1]

Does your PR have changes that can cause upgrade issues?

Component Breaking changes?
MetaDB No
Name registry json No
Data File Descriptor Json No
Export Snapshot Status Json No
Import Data State No
Export Status Json No
Data .sql files of tables No
Export and import data queue No
Schema Dump No
AssessmentDB No
Sizing DB No
Migration Assessment Report Json No
Callhome Json No
YugabyteD Tables No
TargetDB Metadata Tables No

@priyanshi-yb priyanshi-yb changed the title Fix: Not looging the source-replica-db-password in the import-data-to-source-replica command log file Fix: Not logging the source-replica-db-password in the import-data-to-source-replica command log file Dec 19, 2024
@priyanshi-yb priyanshi-yb merged commit ff8bf66 into main Dec 19, 2024
42 of 44 checks passed
@priyanshi-yb priyanshi-yb deleted the priyanshi/fix-log-source-replica-pass branch December 19, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants