Make export-dir, source and target databases dynamic to enable parallel runs #2019
Conversation
shubham-yb
commented
Dec 1, 2024
•
shubham-yb
commented
- Added a dynamically named export dir for each test
- Added the provision to create a different source db for each Oracle test
|
|
shubham-yb
requested review from
sanyamsinghal,
priyanshi-yb and
makalaaneesh
and removed request for
priyanshi-yb
| if [[ "${SOURCE_DB_TYPE}" == "postgresql" || "${SOURCE_DB_TYPE}" == "mysql" ]]; then | ||
| export SOURCE_DB_NAME=${SOURCE_DB_NAME:-"${NORMALIZED_TEST_NAME}_fallb"} | ||
| elif [[ "${SOURCE_DB_TYPE}" == "oracle" ]]; then | ||
| export SOURCE_DB_SCHEMA=${SOURCE_DB_SCHEMA:-"${NORMALIZED_TEST_NAME:0:10}_fallb"} && export SOURCE_DB_SCHEMA=${SOURCE_DB_SCHEMA^^} |
There was a problem hiding this comment.
why :0:10 ? pls add a comment.
what is ^^?
There was a problem hiding this comment.
Using ^^ to make the schema uppercase
| @@ -18,7 +18,7 @@ export REPO_ROOT="${PWD}" | |||
| export SCRIPTS="${REPO_ROOT}/migtests/scripts" | |||
| export TESTS_DIR="${REPO_ROOT}/migtests/tests" | |||
| export TEST_DIR="${TESTS_DIR}/${TEST_NAME}" | |||
| export EXPORT_DIR=${EXPORT_DIR:-"${TEST_DIR}/export-dir"} | |||
| export NORMALIZED_TEST_NAME="$(echo "$TEST_NAME" | tr '/-' '_')" | |||
There was a problem hiding this comment.
where do we get TEST_NAME from to begin with?
There was a problem hiding this comment.
TEST_NAME is passed during the test invocation.
The general pattern is TEST_SCRIPT TEST_NAME
example: run_test.sh pg/datatypes
| @@ -37,6 +37,20 @@ else | |||
| source ${SCRIPTS}/${SOURCE_DB_TYPE}/env.sh | |||
| fi | |||
|
|
|||
| export EXPORT_DIR=${EXPORT_DIR:-"${TEST_DIR}/${NORMALIZED_TEST_NAME}_live_export-dir"} | |||
There was a problem hiding this comment.
Looks like this code is the same for all tests?
if so, can we write this logic in functions.sh? (for determining exportDir, setting SOURCE_DB_NAME, etc.
|
After the merge of b7f29af |
| oracle) | ||
| # Limit schema name to 10 characters for Oracle/Debezium due to 30 character limit | ||
| export SOURCE_DB_SCHEMA=${SOURCE_DB_SCHEMA:-"${NORMALIZED_TEST_NAME:0:10}_${test_suffix}"} |
There was a problem hiding this comment.
nit: you can do the truncate 0:10 also above when generating NORMALIZED_TEST_NAME.
There was a problem hiding this comment.
Keeping it specific to Oracle for now. The longer export-dir name brought out some issues. It'll be good to have that test case.
This reverts commit 0c88b8a.
