Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing a warning message box for problematic settings #1366

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Conversation

yshui
Copy link
Owner

@yshui yshui commented Oct 17, 2024

picom will show you something like this if you have been naughty with your configs.

(typo in this image has been fixed)

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 13.16964% with 389 lines in your changes missing coverage. Please review.

Project coverage is 58.13%. Comparing base (5af574d) to head (81bd3b9).
Report is 11 commits behind head on next.

Files with missing lines Patch % Lines
src/utils/ui.c 0.00% 251 Missing ⚠️
src/picom.c 10.00% 36 Missing ⚠️
src/utils/process.c 0.00% 33 Missing ⚠️
src/config_libconfig.c 49.01% 26 Missing ⚠️
src/config.h 0.00% 15 Missing ⚠️
src/options.c 0.00% 15 Missing ⚠️
src/utils/misc.h 0.00% 6 Missing ⚠️
src/x.c 54.54% 5 Missing ⚠️
src/c2.c 95.45% 1 Missing ⚠️
src/transition/script.c 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1366      +/-   ##
==========================================
- Coverage   59.81%   58.13%   -1.69%     
==========================================
  Files          66       68       +2     
  Lines       13392    13743     +351     
==========================================
- Hits         8011     7989      -22     
- Misses       5381     5754     +373     
Files with missing lines Coverage Δ
src/backend/gl/gl_common.c 65.67% <100.00%> (ø)
src/c2.h 100.00% <ø> (ø)
src/common.h 84.61% <ø> (-7.70%) ⬇️
src/log.h 76.47% <ø> (ø)
src/utils/misc.c 0.00% <ø> (ø)
src/vblank.c 0.00% <ø> (ø)
src/wm/win.c 74.71% <ø> (-0.70%) ⬇️
src/wm/win.h 72.72% <ø> (ø)
src/x.h 83.33% <ø> (ø)
src/c2.c 56.62% <95.45%> (-0.02%) ⬇️
... and 9 more

... and 4 files with indirect coverage changes

@yshui yshui merged commit cf9da5a into next Oct 17, 2024
23 checks passed
@yshui yshui deleted the warning-msgbox branch October 17, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant