Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: added libconfig as a subproject #1267

Merged
merged 1 commit into from
May 30, 2024

Conversation

Monsterovich
Copy link
Contributor

No description provided.

@yshui
Copy link
Owner

yshui commented May 26, 2024

git submodule in general is a pain with work with, so I try to avoid them when possible. and I do want to push debian a little bit to update their libconfig. I am not objecting to adding this but, I would rather prefer either:

  1. a meson wrap file, or
  2. instructions in README about how to build libconfig.

@Monsterovich Monsterovich changed the title misc: added libconfig as submodule misc: added libconfig as a subproject May 26, 2024
@Monsterovich
Copy link
Contributor Author

@yshui

  1. a meson wrap file, or

Done, I went for a master branch because tag v1.7.3 doesn't build, most likely due to a bug in the CMake files which they fixed later.

Copy link
Collaborator

@absolutelynothelix absolutelynothelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it'd be good to squash all this merge commit madness. i personally think it could be a single commit but it's up to you (and yshui).

.gitignore Outdated Show resolved Hide resolved
src/meson.build Outdated Show resolved Hide resolved
subprojects/libconfig.wrap Outdated Show resolved Hide resolved
@Monsterovich Monsterovich force-pushed the feat-static-libconfig branch 2 times, most recently from e80575c to 4a27091 Compare May 30, 2024 13:31
@Monsterovich
Copy link
Contributor Author

also it'd be good to squash all this merge commit madness. i personally think it could be a single commit but it's up to you (and yshui).

Done.

@yshui yshui merged commit f1346a0 into yshui:next May 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants