backend: xrender: small refactoring #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as requested on the discord server. this also addresses clang-tidy issues.
explicit casts are preferred at least according to the discussion in the yshui#343. this also makes the xrender backend's code consistent with the other backends' code.
and sort the xrender_ops structure in the order backend operations are declared in the backend_operations structure. this makes the xrender backend's code consistent with the other backends' code and reduces the risk of collisions because some backend operation names are quite simple (e.g. init, deinit, fill, etc.).
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'm thinking about prefixing everything with
xr_instead ofxrender_as it's a nice and short abbreviation just like vk for vulkan 🤔backend: xrender: drop the leading underscore from structure names
as requested on the discord server. this also addresses clang-tidy
issues.
backend: xrender: prefer explicit casts
explicit casts are preferred at least according to the discussion in
the #343. this also makes the xrender backend's code consistent with the
other backends' code.
backend: xrender: prefix backend-specific function names with xrender_
and sort the xrender_ops structure in the order backend operations are
declared in the backend_operations structure.
this makes the xrender backend's code consistent with the other
backends' code and reduces the risk of collisions because some backend
operation names are quite simple (e.g. init, deinit, fill, etc.).