backend: gl: don't leak gl resources #1183
Conversation
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #1183 +/- ##
==========================================
- Coverage 36.56% 36.48% -0.09%
==========================================
Files 50 50
Lines 11543 11555 +12
==========================================
- Hits 4221 4216 -5
- Misses 7322 7339 +17
|
Signed-off-by: Yuxuan Shui <[email protected]>
There was a problem hiding this comment.
looks good, builds and works for me.
not sure how to make sure that you didn't miss anything but i ran apitrace leaks on a trace generated by picom --config=/dev/null --backend=glx with this pull request applied and it didn't report any leaks. though it doesn't check if the amount of the glCreateProgram/glDeleteProgram and the glGenQueries/glDeleteQueries calls match i checked it manually and it perfectly matches. additionaly, the amount of the glCreateShader/glDeleteShader calls also perfectly matches.
|
|
||
| glDeleteTextures(1, &gd->default_mask_texture); | ||
| glDeleteTextures(1, &gd->back_texture); | ||
|
|
||
| glDeleteQueries(2, gd->frame_timing); |
Merge after #1179