-
-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: separate work with the x extensions #1053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
from
April 23, 2023 20:20
56d1f5d
to
1982232
Compare
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
2 times, most recently
from
May 20, 2024 19:10
2a1b74e
to
c3be2a5
Compare
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
2 times, most recently
from
May 30, 2024 11:17
f5d0796
to
62666b1
Compare
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
2 times, most recently
from
October 18, 2024 21:37
54fc212
to
16617af
Compare
absolutelynothelix
changed the title
core: dependencies cleanup
core: separate work with the x extensions
Oct 18, 2024
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
from
October 30, 2024 10:55
16617af
to
48f40df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yshui, let's resolve a few concerns before merging this.
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
2 times, most recently
from
November 9, 2024 14:36
5fd15d2
to
f5302ee
Compare
absolutelynothelix
force-pushed
the
dependencies-cleanup
branch
from
November 11, 2024 18:20
f5302ee
to
ea391c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
picom/src/x.c
Line 67 in 1648673
x_extensions
that lives in thex_connection
structure, so thesession
structure is less polluted. it's ordered and clean so it's clear how to add and/or remove the x extensions;x_init_extensions
that is called right after thex_init_connection
function, so thesession_init
function is less polluted. it's ordered and clean so it's clear how to add and/or remove the x extensions. also it separates initialization from work (only initialization happens there, all the work left in thesession_init
function), has comments (when a particular x extension initialization happens, why we require particular versions of particular x extensions and why we sometimes negotiate versions of x extensions just to discard this information) and has a better error handling (when a required x extension is missing or something goes wrong it at least tries to free what's already allocated instead of immediately dying usingexit(1)
and leaking a bunch of stuff);--diagnostics
reports presence of all the optional x extensions in the same way now;win_update_bounding_shape
function doesn't requireshape_exists
that indicates the x shape extension presence, it determines it itself usingc
;x_error_code_to_string
function doesn't useps_g
anymore, it usesc
instead;