-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh project + new features #71
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utStrategy with reasonable defaults
…or default strategies
…pping), add addResizer to strategy builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, great job @ypresto with this library, it is extremely useful. More than a PR this is a question. Is this project evolving in some direction?
I have forked the repo and spent a few hours today, doing some basic maintenance. At the time of writing this PR includes:
I plan to work a lot more on this in the next weeks and add new features. Want to do something about input aspect ratio (cropping using OpenGL might be a good solution), and perform actual frame dropping (simply setting the frame rate to the output format does not mean that MediaMuxer is going to do it, AFAIK).
I am happy to contribute to the original repo but there's a lot to be done and speed is important to me at the moment. So if you are open to review / discussions / merging, let's do it! If not, feel free to close this PR and I will work on my fork. As said, I hope to be actively working on the features that I think are missing, and can help you maintain the repo if you want.
Either way, this is a great lib, thank you!