Some more performance improvements #4431
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
force-pushed
the
some_performance_improvements
branch
from
f7d4717
to
d691aea
Compare
jellefoks
force-pushed
the
some_performance_improvements
branch
3 times, most recently
from
ff520f8
to
2e7e377
Compare
This accounted for 25% of CPU time of QuicChromiumPacketWriter::WritePacketToSocketImpl
jellefoks
force-pushed
the
some_performance_improvements
branch
from
2e7e377
to
8112ef7
Compare
jellefoks
changed the title
johnxwork
approved these changes
Nov 21, 2024
jellefoks
force-pushed
the
some_performance_improvements
branch
from
51415cb
to
74bbb5a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Are you sure you want to bundle these changes in a single PR ? Splitting them out and submitting separately makes it easier to revert / cherrypick / bisect where applicable later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more performance improvements. This reduces CPU usage more, lifting achieved bandwidths another 10-15%.
Cumulative versus 25.lts.10, gQUIC bandwidth is now 30-65% improved, and HTTP/3 bandwidth 40-85% improved.
This includes the following changes:
b/205134049