-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EG] Update the EG updater to allow sideloading #4428
base: 25.lts.1+
Are you sure you want to change the base?
Conversation
8d46749
to
2191968
Compare
I added an additional compile check for ALLOW_EVERGREEN_SIDELOADING to enable this feature. We should be able to safely submit this now and fully launch it at a later date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the open comment, LGTM
My understanding is apart from this flag this is asimple cherry-pick of the already reviewed change in trunk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from open comment lgtm
…ur key and to set a custom URL to check for package updates. Implement the above features into the updater for non-gold builds only. Add a stub server for serving packages. b/325626249 Change-Id: I108a1e9549c252ef5befdc239cd70b92545ae8d0
2191968
to
52bc1cc
Compare
Add h5vcc API options to skip checking if package signature matches our key and to set a custom URL to check for package updates.
Implement the above features into the updater for non-gold builds only.
Add a stub server for serving packages.
b/325626249
Original change was reviewed here: #3938