Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EG] Update the EG updater to allow sideloading #4428

Open
wants to merge 1 commit into
base: 25.lts.1+
Choose a base branch
from

Conversation

TyHolc
Copy link
Contributor

@TyHolc TyHolc commented Nov 13, 2024

Add h5vcc API options to skip checking if package signature matches our key and to set a custom URL to check for package updates.

Implement the above features into the updater for non-gold builds only.

Add a stub server for serving packages.

b/325626249

Original change was reviewed here: #3938

@TyHolc
Copy link
Contributor Author

TyHolc commented Nov 14, 2024

I added an additional compile check for ALLOW_EVERGREEN_SIDELOADING to enable this feature. We should be able to safely submit this now and fully launch it at a later date.

Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the open comment, LGTM

My understanding is apart from this flag this is asimple cherry-pick of the already reviewed change in trunk.

Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from open comment lgtm

…ur key and to set a custom URL to check for package updates.

Implement the above features into the updater for non-gold builds only.

Add a stub server for serving packages.

b/325626249

Change-Id: I108a1e9549c252ef5befdc239cd70b92545ae8d0
@niranjanyardi
Copy link
Contributor

@yuying-y @lamdbui do we want this on 24lts and 23lts as well ? are partners updating to those channels ?

@TyHolc
Copy link
Contributor Author

TyHolc commented Nov 19, 2024

@yuying-y @lamdbui do we want this on 24lts and 23lts as well ? are partners updating to those channels ?

I talked with @yuying-y the other day. It seems like we'll only target 25lts and main (though the main changes will likely diverge and need to be re-implemented).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants