npm 배포 설정 #9
Merged
npm 배포 설정 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JjungminLee
approved these changes
Jan 31, 2024
| "type": "git", | ||
| "url": "git+https://github.com/yourssu/YLS-Web.git" | ||
| }, | ||
| "author": "", |
There was a problem hiding this comment.
큰건 아니구! 이거 없어도 되나용? ㅋㅎㅋㅎ
There was a problem hiding this comment.
앜ㅋㅋㅋㅋㅋㅋ 없어도 괜찮아요!! 저희는 author가 좀 유동적이라 생각해서 작성하지 않았슴다 ㅎ
| @@ -39,7 +57,7 @@ | |||
| "react-dom": "^18.2.0", | |||
| "react-router-dom": "^6.21.3", | |||
| "typescript": "^5.2.2", | |||
There was a problem hiding this comment.
ts 관련한 의존성은 devDependencies로 빼는거 어떨까요? 어차피 soomsilV2에 있고, 개발과정에서만 필요한것 같아서용!
There was a problem hiding this comment.
엇 이미 devDependencies에 있는데 혹쉬 다르게 보이시나요.....????
There was a problem hiding this comment.
헉 죄송해요 그 펼치는거 안해서! 잘못봤네영! 머지하셔도 될것 같아용! 수고하셨습니당!!
JjungminLee
approved these changes
Jan 31, 2024
| @@ -39,7 +57,7 @@ | |||
| "react-dom": "^18.2.0", | |||
| "react-router-dom": "^6.21.3", | |||
| "typescript": "^5.2.2", | |||
There was a problem hiding this comment.
헉 죄송해요 그 펼치는거 안해서! 잘못봤네영! 머지하셔도 될것 같아용! 수고하셨습니당!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
(+ 코드오너 파일 같이 수정했습니다)
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?