feat: YLS 구조 변경 및 타임스탬프 생성 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- react, react-dom을 peerDependencies로 추가합니다.
- YLS 사용처에서 이미 axios, react-router-dom을 설치하고 있을 것 같아 수정합니다.
JjungminLee
approved these changes
Jan 26, 2024
| @@ -0,0 +1,45 @@ | |||
| interface LoggerType { | |||
There was a problem hiding this comment.
오 인터페이스로 뺀거 마음편하고 좋습니당 ㅎㅎ
| }; | ||
|
|
||
| return { | ||
| screen, |
There was a problem hiding this comment.
명세상 이렇게 두개만 내보내도 되겠죠?! 내일 회의때 모수한테 한번 물어봐야할것 같아여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
@JjungminLee #1 브랜치에 이어서 살짝 작업을 해봤습니다!
논의가 필요한 부분
LoggerType과 LogPayloadParams을 어떻게 구성할지 논의해야 할 것 같아요!
path를 매번 사용처에서 받아올 것인지, 저희가 url을 보고 판단할 것인지 정해야 할 것 같아요.
LogClick 사용 시 어떤 이벤트를 감지하고 싶은지만 사용처에서 작성하면 YLS 내에서 해당 이벤트를 감지하고, 이벤트마다 name, message를 (서버로) 동일하게 보내야 할 것 같기도 해요,,
LogParamsContext의 경우 당장 필요할 것 같진 않아 보여요!
resolved [FEAT] YLS 구조 변경 및 타임스탬프 생성 #2
3️⃣ 추후 작업
내일 더 자세히 논의하기...~