feat: version 필드 추가 및 Type 변경 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 모든 Type 수정
JjungminLee
approved these changes
Feb 27, 2024
| const res = await postLog(); | ||
| const res = await postLog(remainList); | ||
| if (res.success) { | ||
| SetLocalStorageClear(); |
There was a problem hiding this comment.
궁금한 점: 10개의 로그가 쌓인 상태에서 계속 백엔드 요청 에러가 날 경우,,,, 어떻게 해야 할까요...?
성공시에만 로컬스토리지를 지우는 로직 추가해주셔서 감사합니당!
10개가 쌓인 상태에서도 에러가 난다면 우선 로컬스토리지에는 로그를 계속 적재해 두는게 맞을것 같아요 제가 이슈파서 수정해둘게요!
There was a problem hiding this comment.
+) 머지하시면 수정해서 pr올려둘게용!
There was a problem hiding this comment.
현재 '10개가 쌓인 상태에서 에러가 날 경우에도 로컬스토리지에 로그를 계속 적재해 두는 상태'인 것 같은데 혹쉬 아닐까용??
There was a problem hiding this comment.
아아 맞아요! 그러면 이대로 가도 될것 같아용!!
|
수고하셨어요! 데모 실행화면도 확인했습니다! |
JjungminLee
approved these changes
Feb 27, 2024
| const res = await postLog(); | ||
| const res = await postLog(remainList); | ||
| if (res.success) { | ||
| SetLocalStorageClear(); |
There was a problem hiding this comment.
아아 맞아요! 그러면 이대로 가도 될것 같아용!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치는 변경사항
demo app 기반 실행화면
확인 한 번 부탁드려용~!
3️⃣ 추후 작업
테스트!!!
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?