Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use later stable rust version 1.81.0 to fix the CI #3033

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

musaprg
Copy link
Contributor

@musaprg musaprg commented Dec 30, 2024

This PR bumps the rust toolchain version to 1.81.0 to pass the CI failing due to the following error.

error: failed to compile `cross v0.2.5 (https://github.com/cross-rs/cross#4090beca)`, intermediate artifacts can be found at `/tmp/cargo-installPBmzPf`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  rustc 1.80.0 is not supported by the following package:
    [email protected] requires rustc 1.81
  Either upgrade rustc or select compatible dependency versions with
  `cargo update <name>@<current-ver> --precise <compatible-ver>`
  where `<compatible-ver>` is the latest version supporting rustc 1.80.0

I've briefly checked the compatibility notes section of the release note, but I don't think bumping up the version would affect the youki's code base.

https://releases.rs/docs/1.81.0/#compatibility-notes

Signed-off-by: Kotaro Inoue <[email protected]>
Signed-off-by: Kotaro Inoue <[email protected]>
@musaprg
Copy link
Contributor Author

musaprg commented Dec 30, 2024

The latest stable version appears to be 1.83.0, but I'm not sure if we could bump the dependent version over three minor versions forward instead of bumping a single minor version. What are your thoughts on that?

@musaprg musaprg marked this pull request as ready for review December 30, 2024 15:38
@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 1, 2025
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k
Copy link
Member

utam0k commented Jan 1, 2025

What are your thoughts on that?

We don't have a rule about that, but this PR is worth it.

@utam0k utam0k merged commit 846625c into youki-dev:main Jan 1, 2025
28 of 29 checks passed
@github-actions github-actions bot mentioned this pull request Jan 1, 2025
@musaprg musaprg deleted the use-later-stable-rust-version-1-81-0 branch January 2, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants