feat: allow customize cgroup root path #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fengxsong <[email protected]>
fengxsong
force-pushed
the
customize_cgroup_root
branch
from
f0700fb to
4ce591c
Compare
|
@utam0k PTAL |
|
@fengxsong May I ask you to make it ready? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
- Coverage 65.98% 65.92% -0.06%
==========================================
Files 133 133
Lines 16814 16829 +15
==========================================
Hits 11095 11095
- Misses 5719 5734 +15 |
utam0k
reviewed
Oct 9, 2023
crates/libcgroups/src/common.rs
Outdated
Comment on lines
346
to
350
| let root = if root_path.is_empty() { | ||
| Path::new(DEFAULT_CGROUP_ROOT) | ||
| } else { | ||
| root_path | ||
| }; |
There was a problem hiding this comment.
How about using Option?
https://doc.rust-lang.org/std/option/enum.Option.html#method.unwrap_or_default
There was a problem hiding this comment.
good idea. I've changed it.
utam0k
requested changes
Oct 9, 2023
Signed-off-by: fengxsong <[email protected]>
utam0k
reviewed
Oct 10, 2023
Signed-off-by: fengxsong <[email protected]>
utam0k
approved these changes
Oct 11, 2023
fengxsong
added a commit
to fengxsong/youki
that referenced
this pull request
Oct 13, 2023
Signed-off-by: fengxsong <[email protected]>
fengxsong
added a commit
to fengxsong/youki
that referenced
this pull request
Oct 13, 2023
Signed-off-by: fengxsong <[email protected]>
YJDoc2
added a commit
that referenced
this pull request
Oct 13, 2023
docs: update docs regarding the changes in #2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2392