Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format UUID was set the same UUID into __id and UUID into document #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akitoshka
Copy link

@akitoshka akitoshka commented Aug 30, 2017

Format UUID was set the same for DBRef, UUID into_id and UUID into document.
Now there are two different approachs how the mongo-connector handles UUID.
The first approach looks like into elastic2_doc_manager, doc-manager sets UUID into Elasticsearch as is, using default str method (with '-' delimiters)
The second approach looks like as into formatter, mongo-connector get hex value (without delimiters).
So we have different behaviors if we work with _id or UUID into doc.
It is unexpected behavior so we have to fix this.

@makhdumi
Copy link
Contributor

This would destroy virtually everyone's existing setups. Someone please reject it.

You also modified it in the DefaultDocumentFormatter which is used by more than just the elastic2 docmanager.

For what it's worth, it isn't at all difficult to convert the hex string it's writing into whatever UUID format you need. IMO you should be doing that in your own code when reading from Elasticsearch, or maybe look into Elasticsearch computed fields.

The hex form of the UUID is its true, raw form, totally agnostic to language and what I personally expect and prefer. It is not unexpected behaviour.

@ShaneHarvey
Copy link
Contributor

@akitoshka I don't quite understand the problem you are trying to solve here. Can you provide an example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants