Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not return freed pointer #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ogbiggles
Copy link

Freeing the pointer to allocated memory before returning it to caller is not good. Instead allocating the memory buffer in the the Soundex constructor and freeing it in the destructor allows a valid pointer to be returned from call().

@guneemwelloeux
Copy link

This looks good to me, and definitely leads to some corruption on Macos Monterey 12.7.6 (21H1320)
For example Soundex(4)("buckle") gives 'B240uckle")\n'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants