Create API methods for manipulating with block elements #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
maZahaca
reviewed
May 7, 2024
| }, | ||
| 'accordion-list-item': { | ||
| render: AccordionItem, | ||
| children: ['accordion-list-item-heading', 'accordion-list-item-content'], |
There was a problem hiding this comment.
wondering an issue if you mistype the 'key', or if they will be the same within one plugin for multiple items
| return ( | ||
| <li | ||
| {...attributes} | ||
| className="yoo-accordion-border yoo-accordion-border-[#525252] yoo-accordion-bg-[#303030] yoo-accordion-rounded-none yoo-accordion-relative yoo-accordion-w-full" |
There was a problem hiding this comment.
wondering those two [#525252] is a standard coloring schema for yoopta, or/and might be re-used from somewhere or taken from Props with default values as defined in the code?
packages/accordion/README.md
Outdated
| @@ -0,0 +1,11 @@ | |||
| # `yoopta-accordion` | |||
|
|
|||
| > TODO: description | |||
There was a problem hiding this comment.
Wondering if README is mandatory file for publishing the plugin to npm, it's a bit misleading.
| @@ -0,0 +1,66 @@ | |||
| import { generateId, SlateElement, YooptaBlockData } from '@yoopta/editor'; | |||
There was a problem hiding this comment.
I have a very strong feeling that example should be stored within plugin and be generated to the website by Lerna, e.g.
in your plugin you have:
./README.md - docs
./test - tests folder
./example/
Also it gives a bit more understanding to the person who looks into the plugin repo of how to use it.
|
In overall I think we can easily split this PR to smaller chunks (worth in future):
|
…feature-simplify-api-for-creating-custom-plugin
…feature-simplify-api-for-creating-custom-plugin
…feature-simplify-api-for-creating-custom-plugin
- @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected]
- @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected]
- @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected]
- @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected]
- @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected] - @yoopta/[email protected]
Darginec05
deleted the
131-feature-simplify-api-for-creating-custom-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR about:
getElement, createElement, deleteElement@yoopta/accordionpackageElementsandBlocksFixed issues:
#131
#174
#176
#175