Check initContainers if they have env vars from a configmap or a secret #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 43.39% 43.43% +0.03%
==========================================
Files 63 63
Lines 4019 4043 +24
==========================================
+ Hits 1744 1756 +12
- Misses 2029 2039 +10
- Partials 246 248 +2 ☔ View full report in Codecov by Sentry. |
almilaneze
force-pushed
the
bug385-initcont-cm-sec
branch
from
93affb4 to
ab12334
Compare
yonahd
reviewed
Dec 7, 2024
almilaneze
force-pushed
the
bug385-initcont-cm-sec
branch
from
751571f to
1a2d93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Configmaps and secrets which were used only to provide env vars from them to an initContainer were wrongly evaluated as not used as there was not validation for this use case. Removal of such a cm or secret will prevent the POD from starting successfully.
PR Checklist
GitHub Issue
Closes [#385 ]
Notes for your reviewers