Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Multiple Python Versions (+3.13 Support) #20

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

TheTechromancer
Copy link

@TheTechromancer TheTechromancer commented Nov 7, 2024

Hey, first off thanks for making this library! It works perfectly and is by far the best such library we've found for Python. Compiling Tika using GraalVM was an awesome idea.

We are working on adding Python 3.13 support to our project, which uses extractous. This PR updates the Python version and also the CI to test multiple python versions, including Python 3.13. PyO3 recently added support.

image

Downstream issue:

@nmammeri
Copy link
Contributor

nmammeri commented Nov 8, 2024

Thanks for the pull request. We are glad that you like extractous.

It seems that pyo3 have support for python 3.13. We should upgrade to ver 0.22.6.

@TheTechromancer
Copy link
Author

We should upgrade to ver 0.22.6.

I updated PyO3 and separated out the python version tests into their own job. Tests should pass now 🤞

@nmammeri
Copy link
Contributor

nmammeri commented Nov 8, 2024

I think what you had before this latest commit is better. We need just to add the python-version when uploading the artifact.

@TheTechromancer
Copy link
Author

Should we upload all the wheel versions? I think we should only need the lowest one, i.e. 3.8.

@nmammeri
Copy link
Contributor

nmammeri commented Nov 8, 2024

The Upload wheels step just uploads them to Github, then the Pytest step downloads them and run the tests.

Uploading to PyPi I'm not really sure what's the common practice for python. It might be as you said, we only need to upload the lowest possible one

@TheTechromancer
Copy link
Author

This should be g2g

@TheTechromancer
Copy link
Author

@nmammeri any news on when this might be merged?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants