-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Multiple Python Versions (+3.13 Support) #20
base: main
Are you sure you want to change the base?
Test Multiple Python Versions (+3.13 Support) #20
Conversation
Thanks for the pull request. We are glad that you like extractous. It seems that pyo3 have support for python 3.13. We should upgrade to ver 0.22.6. |
I updated PyO3 and separated out the python version tests into their own job. Tests should pass now 🤞 |
I think what you had before this latest commit is better. We need just to add the python-version when uploading the artifact. |
Should we upload all the wheel versions? I think we should only need the lowest one, i.e. |
The Upload wheels step just uploads them to Github, then the Pytest step downloads them and run the tests. Uploading to PyPi I'm not really sure what's the common practice for python. It might be as you said, we only need to upload the lowest possible one |
This should be g2g |
@nmammeri any news on when this might be merged? Thanks |
Hey, first off thanks for making this library! It works perfectly and is by far the best such library we've found for Python. Compiling Tika using GraalVM was an awesome idea.
We are working on adding Python 3.13 support to our project, which uses extractous. This PR updates the Python version and also the CI to test multiple python versions, including Python 3.13. PyO3 recently added support.
Downstream issue: