Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure spillmap entries are properly killed where necessary. #219

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

vext01
Copy link

@vext01 vext01 commented Dec 12, 2024

In a couple of places we were failing to clear associations between locations where an MIR instruction defined or killed a register. This lead to us deopting dead stale values at runtime.

@vext01
Copy link
Author

vext01 commented Dec 12, 2024

I'll mark this ready once we've heard the benchmarks run without crashes.

@vext01
Copy link
Author

vext01 commented Dec 12, 2024

Benchmarks are go! Ready for merge.

@ltratt ltratt added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@ltratt
Copy link

ltratt commented Dec 12, 2024

Please force push an update to the failing test (I think it's a simple fix).

In a couple of places we were failing to clear associations between
locations where an MIR instruction defined or killed a register. This
lead to us deopting dead stale values at runtime.

Co-authored-by: Lukas Diekmann <[email protected]>
@vext01 vext01 force-pushed the properly-kill-spillmap branch from edbb5ca to 61c1f9a Compare December 13, 2024 10:31
@vext01
Copy link
Author

vext01 commented Dec 13, 2024

force pushed the fix.

@ltratt ltratt added this pull request to the merge queue Dec 13, 2024
Merged via the queue into ykjit:main with commit 172202a Dec 13, 2024
2 checks passed
@vext01 vext01 deleted the properly-kill-spillmap branch December 13, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants