Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #137

Merged
merged 10 commits into from
May 28, 2024
Merged

Tests #137

merged 10 commits into from
May 28, 2024

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Mar 3, 2024

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

yiisoft/yii-debug#248

Copy link

what-the-diff bot commented Mar 3, 2024

PR Summary

  • Integration of Http Message Library
    The necessary package httpsoft/http-message version ^1.1 was added into the project for HTTP message handling functionalities, i.e. to manage HTTP requests, responses, uploaded files etc which aids in better overall communication process in the application.

  • Code Cleanup in DebugApiProvider.php
    An unnecessary import Psr\Container\ContainerInterface has been removed, which resulted in cleaner and easy to understand code in DebugApiProvider.php.

  • Improvement of Function Argument in DebugApiProvider.php
    The argument type in RouteCollectorInterface closure was updated in DebugApiProvider.php for increased code consistency and reliability.

  • Optimization in CollectorRepository.php
    An enhancement was made by changing the (string)$name code in CollectorRepository.php to improve code efficiency.

  • Added New Files for Testing & Stubbing
    New test files have been added DebugHeadersTest.php, ResponseDataWrapperTest.php, DebugApiProviderTest.php, CollectorRepositoryTest.php. These files help in ensuring the individual functionalities work as expected and improves the overall stability of the application.
    Additionally, a new file StubCollector.php was added which helps in providing a temporary substitute for yet-to-develop or sensitive functionalities during testing phase.

@vjik vjik added the status:under development Someone is working on a pull request. label Mar 4, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.37%. Comparing base (e4a6c26) to head (57195e0).
Report is 3 commits behind head on master.

Current head 57195e0 differs from pull request most recent head 85291b4

Please upload reports for the commit 85291b4 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             master    #137      +/-   ##
===========================================
+ Coverage      3.01%   9.37%   +6.35%     
  Complexity      255     255              
===========================================
  Files            22      22              
  Lines          1325    1302      -23     
===========================================
+ Hits             40     122      +82     
+ Misses         1285    1180     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark requested a review from vjik March 5, 2024 19:53
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix tests in windows

@xepozz xepozz merged commit b29b84c into master May 28, 2024
15 of 16 checks passed
@xepozz xepozz deleted the tests branch May 28, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:under development Someone is working on a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants