Problem: no trace detail on insufficient balance fix is not included (c…

…rypto-org-chain#1681)
yihuang · Nov 8, 2024 · a4a57aa · a4a57aa
1 parent 66f7184
commit a4a57aa
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### Bug Fixes
 
 * [#1670](https://github.com/crypto-org-chain/cronos/pull/1670) Fix state overwrite in debug trace APIs.
+* [#1679](https://github.com/crypto-org-chain/cronos/pull/1679) Include no trace detail on insufficient balance fix.
 
 *Oct 14, 2024*
 

diff --git a/go.mod b/go.mod
@@ -249,7 +249,7 @@ replace (
 	// TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134
 	github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
 	github.com/ethereum/go-ethereum => github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e
-	github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20241104051437-1e621c7767f3
+	github.com/evmos/ethermint => github.com/crypto-org-chain/ethermint v0.6.1-0.20241108024404-f6d137b91faa
 	// Fix upstream GHSA-h395-qcrw-5vmq and GHSA-3vp4-m3rf-835h vulnerabilities.
 	// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
 	github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0

diff --git a/go.sum b/go.sum
@@ -491,8 +491,8 @@ github.com/crypto-org-chain/cometbft-db v0.0.0-20231011055109-57922ac52a63 h1:R1
 github.com/crypto-org-chain/cometbft-db v0.0.0-20231011055109-57922ac52a63/go.mod h1:rocwIfnS+kA060x64gkSIRvWB9StSppIkJuo5MWzL24=
 github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20241008100047-e671aed24d19 h1:e45niobYERw7QF6viZe5KhIH8eLgDTtg+mT5HsVhqCs=
 github.com/crypto-org-chain/cosmos-sdk v0.46.0-beta2.0.20241008100047-e671aed24d19/go.mod h1:vdMQLvLSGh56GqAAQP/w2R389j+g+hHOIwKcUNt9yAc=
-github.com/crypto-org-chain/ethermint v0.6.1-0.20241104051437-1e621c7767f3 h1:U7qSRJ5g85AOX6KJwcBHUFanhYhFh/1HjHGVZx6Adzo=
-github.com/crypto-org-chain/ethermint v0.6.1-0.20241104051437-1e621c7767f3/go.mod h1:zJYmx1D+tDggzvXmdJ0/I62TeIykdCMfJBjBxOcniAU=
+github.com/crypto-org-chain/ethermint v0.6.1-0.20241108024404-f6d137b91faa h1:Ja8mrktznbXLxC97HtkL9OSMQNVpOuBlOvWv8WrjaEE=
+github.com/crypto-org-chain/ethermint v0.6.1-0.20241108024404-f6d137b91faa/go.mod h1:zJYmx1D+tDggzvXmdJ0/I62TeIykdCMfJBjBxOcniAU=
 github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e h1:vnyepPQ/m25+19xcTuBUdRxmltZ/EjVWNqEjhg7Ummk=
 github.com/crypto-org-chain/go-ethereum v1.10.20-0.20231207063621-43cf32d91c3e/go.mod h1:+a8pUj1tOyJ2RinsNQD4326YS+leSoKGiG/uVVb0x6Y=
 github.com/crypto-org-chain/gravity-bridge/module/v2 v2.0.1-0.20230825054824-75403cd90c6e h1:rSTc35OBjjCBx47rHPWBCIHNGPbMnEj8f7fNcK2TjVI=

diff --git a/gomod2nix.toml b/gomod2nix.toml
@@ -219,8 +219,8 @@ schema = 3
     hash = "sha256-lDIqRLUrXYCb9mmFBY/+WW+ee69+IkxOgqjHVyo4ij0="
     replaced = "github.com/crypto-org-chain/go-ethereum"
   [mod."github.com/evmos/ethermint"]
-    version = "v0.6.1-0.20241104051437-1e621c7767f3"
-    hash = "sha256-0LzVvyOOuPayc5259gBTJMLml9ctJuFVtzLzIAwY9uY="
+    version = "v0.6.1-0.20241108024404-f6d137b91faa"
+    hash = "sha256-SpUrlh0LksBxZUsw4WM+PPoXe9FouhBgLiTCf2WLxgM="
     replaced = "github.com/crypto-org-chain/ethermint"
   [mod."github.com/felixge/httpsnoop"]
     version = "v1.0.4"

diff --git a/integration_tests/test_basic.py b/integration_tests/test_basic.py
@@ -821,12 +821,11 @@ def test_failed_transfer_tx(cronos):
             assert not result["failed"]
             assert receipt.gasUsed == result["gas"]
         else:
-            assert rsp["error"] == {
-                "code": -32000,
-                "message": (
-                    "rpc error: code = Internal desc = "
-                    "insufficient balance for transfer"
-                ),
+            assert rsp["result"] == {
+                "failed": False,
+                "gas": 21000,
+                "returnValue": "",
+                "structLogs": [],
             }