Added back compile-test to the default in build.xml.

yihua · Dec 25, 2014 · 919fc9f · 919fc9f
1 parent 6ba1f9d
commit 919fc9f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/build.xml b/build.xml
@@ -243,7 +243,7 @@
     </target>
     <target name="coverage" depends="instrument,test,coverage-report"/>
 
-    <target name="dist" depends="compile">
+    <target name="dist" depends="compile,compile-test">
         <jar destfile="${floodlight-jar}" filesetmanifest="mergewithoutmain">
             <manifest>
                 <attribute name="Main-Class" value="${main-class}"/>

diff --git a/...main/java/net/floodlightcontroller/staticflowentry/web/StaticFlowEntryPusherResource.java b/...main/java/net/floodlightcontroller/staticflowentry/web/StaticFlowEntryPusherResource.java
@@ -176,7 +176,7 @@ private int checkFlow(Map<String, Object> rows) {
 			if (icmp6_type == true) {
 				//icmp_type must be set to 135/136 to set ipv6_nd_target
 				if (nd_target == true) {
-					if (!(icmp_type == 135 || icmp_type == 136)) {
+					if (!(icmp_type == 135 || icmp_type == 136)) { /* or 0x87 / 0x88 */
 						//invalid icmp6_type
 						state = 6;
 						return state;

diff --git a/src/main/java/net/floodlightcontroller/util/MatchUtils.java b/src/main/java/net/floodlightcontroller/util/MatchUtils.java
@@ -428,7 +428,11 @@ public static Match fromString(String match, OFVersion ofVersion) throws Illegal
 				if (ver10 == true) {
 					throw new IllegalArgumentException("OF Version incompatible");
 				}
-				mb.setExact(MatchField.IPV6_FLABEL, IPv6FlowLabel.of(Integer.parseInt(key_value[1])));
+				if (key_value[1].startsWith("0x")) { 
+					mb.setExact(MatchField.IPV6_FLABEL, IPv6FlowLabel.of(Integer.parseInt(key_value[1].replaceFirst("0x", ""), 16)));
+				} else {
+					mb.setExact(MatchField.IPV6_FLABEL, IPv6FlowLabel.of(Integer.parseInt(key_value[1])));
+				}
 				break;
 //sanjivini