fix claimDelayedWithdrawals to not pull on its own #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danoctavian
changed the base branch from
audit/yieldnest-mvp
to
release-candidate
danoctavian
force-pushed
the
fix/claimDelayedWithdrawals-external-call
branch
2 times, most recently
from
2043fa8 to
e9bdd6a
Compare
danoctavian
force-pushed
the
fix/claimDelayedWithdrawals-external-call
branch
from
e9bdd6a to
9181157
Compare
danoctavian
force-pushed
the
fix/claimDelayedWithdrawals-external-call
branch
from
d9478c8 to
b0c358c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DelayedWithdrawalRouter.claimDelayedWithdrawals can be called by anyone.
Existing logic assumes it's permissioned (it's not).
Refactor code so that you can support that assuming anyone can call it.
The way to solve that is to register withdrawn validators before pulling the funds.
This way you don't tax principal and it's just put back into the pool