Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a series of new test scenarios for the ynETH contract, aimed at rigorously evaluating its functionality and ensuring its robustness in various operational contexts.
This scenario tests the core functionality where users can deposit ETH and receive the correct amount of shares in return. It validates the integrity of total assets, share balances, total deposited in the pool, and the total supply of ynETH, ensuring that the contract behaves as expected when handling deposits.
This scenario ensures that the ynETH contract can correctly pause and resume deposits, a critical feature for managing the contract under various conditions. It tests the contract's response to deposit attempts when paused and verifies that normal operations resume once deposits are unpaused.
Focusing on the interaction with the Staking Nodes Manager, this scenario tests the contract's ability to deposit ETH, delegate responsibilities, and withdraw ETH exclusively by the Staking Nodes Manager. This scenario is crucial for validating the contract's integration with staking mechanisms.
Scenario 4: Share Accounting and Yield Accrual
[ ]
This scenario is designed to verify that the share price correctly increases following the contract's earnings from consensus and execution rewards. It's essential for ensuring that the contract accurately accounts for yields and adjusts share values accordingly.
Scenario 5: Withdrawal of ETH
The final scenario tests the ynETH contract's ability to withdraw ETH to the Staking Nodes Manager, ensuring that withdrawals are processed correctly and only by authorized entities.