Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ynETH Scenario Tests #41

Closed
wants to merge 14 commits into from
Closed

Conversation

xhad
Copy link
Contributor

@xhad xhad commented Mar 16, 2024

This PR introduces a series of new test scenarios for the ynETH contract, aimed at rigorously evaluating its functionality and ensuring its robustness in various operational contexts.

  • Scenario 1: Successful ETH Deposit and Share Minting

This scenario tests the core functionality where users can deposit ETH and receive the correct amount of shares in return. It validates the integrity of total assets, share balances, total deposited in the pool, and the total supply of ynETH, ensuring that the contract behaves as expected when handling deposits.

  • Scenario 2: Deposit Paused and Resumed

This scenario ensures that the ynETH contract can correctly pause and resume deposits, a critical feature for managing the contract under various conditions. It tests the contract's response to deposit attempts when paused and verifies that normal operations resume once deposits are unpaused.

  • Scenario 3: Deposit, Delegate, and Withdraw ETH to Staking Nodes Manager

Focusing on the interaction with the Staking Nodes Manager, this scenario tests the contract's ability to deposit ETH, delegate responsibilities, and withdraw ETH exclusively by the Staking Nodes Manager. This scenario is crucial for validating the contract's integration with staking mechanisms.

  • Scenario 4: Share Accounting and Yield Accrual

  • [ ]
    This scenario is designed to verify that the share price correctly increases following the contract's earnings from consensus and execution rewards. It's essential for ensuring that the contract accurately accounts for yields and adjusts share values accordingly.

  • Scenario 5: Withdrawal of ETH

The final scenario tests the ynETH contract's ability to withdraw ETH to the Staking Nodes Manager, ensuring that withdrawals are processed correctly and only by authorized entities.

Copy link

This pull request has been linked to Shortcut Story #193: Add Scenario Based Testing for ynETH deposit flow.

@xhad xhad force-pushed the chad/sc-193/yneth-spec-test branch from 6290a7f to 9e681f4 Compare March 16, 2024 03:04
@xhad xhad closed this Mar 16, 2024
@xhad xhad deleted the chad/sc-193/yneth-spec-test branch March 16, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant