Fixes StakingNodesManager tests and adds github actions to run forge tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #133: Add test coverage for all remaining modules to ensure close to 100% test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issues with
StakingNodesManager.t.solthat were introduced on the previous merge. The issue was related to attempts to abstract mock validator node data creation into it's own contract to be used across other tests. That has been reverted and is only used in one test contract withinStakingNodesManagerfor now.Also, this adds a github actions yaml to run forge tests. This will require setting
MAINNET_RPC_URLin the github settings secrets page here.