feat: increase test coverage #135
Conversation
depositETH with referral
…oostrap amount - WIP
|
|
||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
these tests shouldn't be deleted, not sure what was the intention here
There was a problem hiding this comment.
blunder. added in last commit
|
Let's rebase this branch (yneigen-increase-test-coverage) on top of the base branch (feature/yneigen) to resolve conflicts |
johnnyonline
force-pushed
the
yneigen-increase-test-coverage
branch
from
9838f34 to
e41c794
Compare
danoctavian
force-pushed
the
feature/yneigen
branch
from
db29045 to
508e830
Compare
| @@ -352,9 +352,9 @@ contract YnETHScenarioTest10 is IntegrationBaseTest, YnETHScenarioTest3 { | |||
| // The SelfDestructSender contract is created with the amountToSend and immediately self-destructs, | |||
| // sending its balance to the target address. | |||
| address(new SelfDestructSender{value: amountToSendViaSelfDestruct}(target)); | |||
|
|
|||
There was a problem hiding this comment.
Generally if you don't want to change a file just revert it back to the version on the base branch, so there's no random changes in it
test/scenarios/ynLSD.spec.sol
Outdated
|
|
||
| // should fail when not on the pause whitelist | ||
| ynEigenToken.approve(user2, amount); | ||
| vm.expectRevert(bytes4(keccak256(abi.encodePacked("TransfersPaused()")))); |
There was a problem hiding this comment.
please use expectRevert with TransfersPaused.selector as in the other tests for consistency
test/scenarios/ynLSD.spec.sol
Outdated
| } | ||
| } | ||
|
|
||
| contract YnLSDScenarioTest2 is ynEigenIntegrationBaseTest { |
There was a problem hiding this comment.
call it YnEigenScenarioTest2
| import { Invariants } from "test/scenarios/Invariants.sol"; | ||
| import { IERC20 } from "lib/openzeppelin-contracts/contracts/interfaces/IERC20.sol"; | ||
| import { TestAssetUtils } from "test/utils/TestAssetUtils.sol"; | ||
| import {Invariants} from "./Invariants.sol"; |
There was a problem hiding this comment.
the identation in this file is messed up, it uses 8 spaces intead of 4
There was a problem hiding this comment.
hmm not sure what you're referring to here
There was a problem hiding this comment.
I had this issue as well @johnnyonline... I had to change my cursor/vscode settings to use spaces, instead of tabs. Might be the cause of this one for you too
test/scenarios/ynLSD.spec.sol
Outdated
| vm.stopPrank(); | ||
| } | ||
|
|
||
| function test_ynLSD_Scenario_2_Unpause() public { |
There was a problem hiding this comment.
change all places to have ynEigen
| } | ||
|
|
||
| // | src/ynEIGEN/ynEigen.sol | 85.25% (52/61) | 87.67% (64/73) | 100.00% (20/20) | 75.00% (12/16) |
There was a problem hiding this comment.
it's good you measured this but let's not put it in the file, just leave it in the description of the PR.
It becomes a chore to keep updating it as we add code or add tests.
danoctavian
force-pushed
the
feature/yneigen
branch
from
09125cc to
fb3a43c
Compare
No description provided.