Fix audit issue 8.9

yieldnest · Mar 29, 2024 · aef66d1 · aef66d1
1 parent ced5c5f
commit aef66d1
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/ynLSD.sol b/src/ynLSD.sol
@@ -355,14 +355,15 @@ contract ynLSD is IynLSD, ynBase, ReentrancyGuardUpgradeable, IynLSDEvents {
         onlyRole(LSD_STAKING_NODE_CREATOR_ROLE)
         returns (ILSDStakingNode) {
 
-        if (nodes.length >= maxNodeCount) {
+        uint256 nodeId = nodes.length;
+
+        if (nodeId >= maxNodeCount) {
             revert TooManyStakingNodes(maxNodeCount);
         }
 
         BeaconProxy proxy = new BeaconProxy(address(upgradeableBeacon), "");
         ILSDStakingNode node = ILSDStakingNode(payable(proxy));
 
-        uint256 nodeId = nodes.length;
         initializeLSDStakingNode(node);
 
         nodes.push(node);