Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos ci and, add lts-20/22, remove lts-14 #1839

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Conversation

dten
Copy link
Contributor

@dten dten commented Jul 16, 2024

Before submitting your PR, check that you've:

After submitting your PR:

  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@dten dten changed the title Fix macos ci Draft: Fix macos ci Jul 16, 2024
@dten dten force-pushed the macosci branch 4 times, most recently from 445704a to b027a28 Compare July 16, 2024 14:19
@dten dten changed the title Draft: Fix macos ci Fix macos ci Jul 16, 2024
dten added 2 commits July 16, 2024 15:44
ghc 8 not happy no macos-latest
nightly (seemingly there to target 9.0) replaced with higher lts versions
@dten dten changed the title Fix macos ci Fix macos ci and test lts-20/22 Jul 16, 2024
@dten
Copy link
Contributor Author

dten commented Jul 16, 2024

the windows ci is a bit flakey but this hasn't made it worse

yesodweb#1838 will drop support for ghc 8.6
@dten
Copy link
Contributor Author

dten commented Jul 16, 2024

since #1838 will be dropping 8.6 support i've also removed lts-14 from the tests

@dten dten changed the title Fix macos ci and test lts-20/22 Fix macos ci and, add lts-20/22, remove lts-14 Jul 16, 2024
Copy link
Member

@jezen jezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@jezen jezen merged commit b9f4d69 into yesodweb:master Jul 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants