Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consensus 2nd tx should not finish before 1st tx #759

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

fix: consensus 2nd tx should not finish before 1st tx #759

wants to merge 35 commits into from

Conversation

kstroobants
Copy link
Contributor

@kstroobants kstroobants commented Dec 17, 2024 •
edited
Loading

Fixes #661

What

  • Add check to finalize the transaction only if the previous transaction is finalized

Why

  • To fix a bug

Testing done

  • Tested the bug fix in the studio

Decisions made

Checks

  • I have tested this code
  • I have reviewed my own PR
  • I have created an issue for this PR
  • I have set a descriptive PR title compliant with conventional commits

Reviewing tips

Try in the studio

User facing release notes

The transaction can only be finalized if the previous transaction is finalized.

kstroobants and others added 30 commits October 22, 2024 15:24
@kstroobants
feat: add rollup transaction db table
021f10e
@kstroobants
fix: drop audit table, change id and nonce of rollup, only make one f…
eca17e5 
…inalized rollup transaction
@kstroobants
create rollup transaction for every validator
9184749
@kstroobants
add function to mock in consensus test
6daee80
@kstroobants
feat: add appeal window, accepted queue, basic test
90ea2c1
@kstroobants
fix: old tests were stuck on accepted state, add usage of thread
bb30590
@kstroobants
refactor consensus into states
1e1958c
@kstroobants
feat: added appeal flow when transaction is accepted including the lo…
2708f13 
…op when appeal failed and succeeded
@kstroobants
fix: adding tests for appeals and fixing minor bugs
e3fffde
@kstroobants
refactor: merge main and PR #573 into this branch
3d00e34
@kstroobants
feat: add appeal_failed in db, select new validators when appealed ba…
f5c3af1 
…sed on formula
@kstroobants
docs: cleanup consensus mechanism base file
27624bb
@kstroobants
test: checking the number of validators for different appeals
d315fd1
@kstroobants
feat: adding appeal window to undetermined state
76b0f6d
@kstroobants
feat: change timestamp_accepted and add appeal_undetermined in database
00e90e1
@kstroobants
feat: undetermined to pending, activate frontend button in undetermin…
4dfe115 
…ed state and add button also to modal
@kstroobants
feat: leader only has no appeal button and no appeal window
9cc27f1
@kstroobants
feat: implement the state transitions to process the appeal
33a7f33 
- Add N+2 validators, remove leader
- Use latest data of transaction when in pending state and not the old one from the crawler
- Write consensus data before setting status to have it updated in frontend when going to transaction info modal
- Do not deploy contract when transaction was in the undetermined state
@kstroobants
test: add test for leader appeals
f2c626e
@kstroobants
refactor: merge 593-appeals-add-validators-when-appealed into 604-app…
b843377 
…eals-implement-sequential-appeals-fail
@kstroobants
refactor: merge 604-appeals-implement-sequential-appeals-fail into 63…
b7daed7 
…8-appeals-undetermined-transactions
@kstroobants
refactor: merge main into 604-appeals-implement-sequential-appeals-fail
be2be7d
@kstroobants
refactor: merging changed file permissions
afb13f6
@kstroobants
Merge branch 'main' into 604-appeals-implement-sequential-appeals-fail
1311304
@kstroobants
fix: appealing a write method gave a KeyError because of wrong conver…
a14ef91 
…sation of transaction
@kstroobants
docs: update transaction_processor argument description
70a85cf
@kstroobants
fix: all appeals disagreed because of pending_transactions type
f34870e
@kstroobants
merge 604-appeals-implement-sequential-appeals-fail into 638-appeals-…
089d7af 
…undetermined-transactions
@kstroobants
refactor: undo change because of merge
722501f
@kstroobants
fix: do not reset finality window when leader appeal failed, leader_o…
e2c9d4a 
…nly check in appeal_window
@kstroobants kstroobants self-assigned this Dec 17, 2024
@kstroobants kstroobants linked an issue Dec 17, 2024 that may be closed by this pull request
Consensus: 2nd tx should not finish before 1st tx #661
Open
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cristiam86
Copy link
Collaborator

@kstroobants please solve the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiam86 cristiam86 Awaiting requested review from cristiam86

At least 1 approving review is required to merge this pull request.

Assignees

@kstroobants kstroobants

Labels
run-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consensus: 2nd tx should not finish before 1st tx
2 participants
@kstroobants @cristiam86